Codecov Report

Merging #802 (99211f4) into master (9449fdc) will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #802      +/-   ##
==========================================
+ Coverage   85.76%   85.90%   +0.13%     
==========================================
  Files          34       35       +1     
  Lines        3865     3882      +17     
  Branches      993      998       +5     
==========================================
+ Hits         3315     3335      +20     
- Misses        353      354       +1     
+ Partials      197      193       -4     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9449fdc...99211f4. Read the comment docs.

While running the notebooks I am getting a warning on one of the test datasets about its dataset_description.

Is this intentional ? Maybe to test the CLI pybids update ?

root = os.path.join(get_test_data_path(), "synthetic")
layout2 = BIDSLayout(root, derivatives=True)

/home/remi/github/pybids/bids/layout/validation.py:151: UserWarning: The PipelineDescription field was superseded by GeneratedBy in BIDS 1.4.0. You can use ``pybids upgrade`` to update your derivative dataset.
  warnings.warn("The PipelineDescription field was superseded "

No, the test dataset predates the derivatives release.

No, the test dataset predates the derivatives release.

Want a quick separate PR to fix this ?

Sure. Might be good to keep the old one to test upgrade, and then use the upgraded one for smooth notebooking.

Quick question so I don't non-sense in those examples.

Is it the expected behavior that parse_file_entities cannot recover the subject entity when only given the filename instead of the relative path?

from bids import BIDSLayout
from bids.tests import get_test_data_path
import os

data_path = os.path.join(get_test_data_path(), "7t_trt")
print(f"Initializing layout with: {data_path}")

layout = BIDSLayout(data_path)

# relative path
layout.parse_file_entities("sub-01/ses-1/anat/sub-01_ses-1_T1map.nii.gz")
>>> 
{'subject': '01',
 'session': '1',
 'suffix': 'T1map',
 'datatype': 'anat',
 'extension': '.nii.gz'}

# filename only
layout.parse_file_entities("sub-01_ses-1_T1map.nii.gz")
>>> 
{'session': '1', 'suffix': 'T1map', 'extension': '.nii.gz'}

That the datatype is not recovered from just the filename makes sense, but I am not sure why the subject is not parsed? Something I am missing?

Similarly using get_file with just the filename returns None

Guessing that parse_file_entities expects a full path, so layout.parse_file_entities("sub-01/ses-1/anat/sub-01_ses-1_T1map.nii.gz"), but I would expect it to do its best without the full path.